AmoghAtreya opened a new pull request, #44958:
URL: https://github.com/apache/superset/pull/44958

   ### SUMMARY
   
   Fixes datasource metadata refresh when switching datasets in Explore.
   
   `ExploreViewContainer` previously called the `fetchDatasourceMetadata` thunk 
creator directly. This created a thunk function but did not dispatch it, so the 
metadata request never ran.
   
   This change:
   
   - Binds `fetchDatasourceMetadata` through `mapDispatchToProps`.
   - Calls the bound action when the datasource control changes.
   - Adds a regression test confirming that changing the datasource requests 
metadata for the new datasource.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not applicable. This fixes data-fetching behavior without changing the 
visual interface.
   
   ### TESTING INSTRUCTIONS
   
   Run the ExploreViewContainer test suite:
   
   ```bash
   cd superset-frontend
   npm run test -- 
src/explore/components/ExploreViewContainer/ExploreViewContainer.test.tsx
   ```
   
   Expected result:
   
   - The test suite passes with 30 tests.
   - The regression test verifies that changing the datasource calls 
`/fetch_datasource_metadata` with the new datasource key.
   
   Manual verification:
   
   1. Open an existing chart in Explore.
   2. Change its datasource.
   3. Confirm that metadata for the selected datasource loads and its columns 
and metrics are available.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: Fixes #44915
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to