codeant-ai-for-open-source[bot] commented on code in PR #44958:
URL: https://github.com/apache/superset/pull/44958#discussion_r4174559793
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.tsx:
##########
@@ -704,8 +704,7 @@ function ExploreViewContainer(props:
ExploreViewContainerProps) {
(previousControls.datasource == null ||
props.controls.datasource.value !==
previousControls.datasource.value)
) {
- // this should really be handled by actions
- fetchDatasourceMetadata(props.form_data.datasource);
+ props.actions.fetchDatasourceMetadata(props.form_data.datasource);
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `5ffa318`.
The datasource metadata thunk is wrapped with
`Promise.resolve(...).catch(...)`, and failures now display a danger toast
instead of becoming unhandled promise rejections.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
