bito-code-review[bot] commented on PR #44968: URL: https://github.com/apache/superset/pull/44968#issuecomment-5983903952
<!-- Bito Reply --> The review comment is correct. The documentation in `docs/admin_docs/security/security.mdx` incorrectly implies that `catalog_access` is restricted to a single schema, whereas it actually authorizes access across the entire catalog. To resolve this, the sentence should be updated to clarify that `catalog_access` provides broader scope. I have implemented the correction below: ```md - `schema_access` and `catalog_access` let the user browse that schema in SQL Lab and still authorize charts, but they do not authorize query execution. + `schema_access` lets the user browse that schema in SQL Lab, and `catalog_access` lets the user browse the catalog, and both still authorize charts, but they do not authorize query execution. ``` I have checked the other comments on this PR. Would you like me to fetch all comments, validate them, and implement fixes for the rest as well? **docs/admin_docs/security/security.mdx** ``` - `schema_access` and `catalog_access` let the user browse that schema in SQL Lab and still authorize charts, but they do not authorize query execution. + `schema_access` lets the user browse that schema in SQL Lab, and `catalog_access` lets the user browse the catalog, and both still authorize charts, but they do not authorize query execution. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
