AmoghAtreya commented on code in PR #44968: URL: https://github.com/apache/superset/pull/44968#discussion_r4179530881
########## tests/unit_tests/sqllab/test_requires_dataset_match.py: ########## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from unittest.mock import patch + +from flask import current_app +from pytest_mock import MockerFixture + +from superset.sqllab.utils import requires_dataset_match +from superset.sqllab.validators import CanAccessQueryValidatorImpl + + +def test_requires_dataset_match_defaults_to_true() -> None: + """A missing config key keeps the dataset-match requirement on.""" + config = current_app.config + original = config.pop("SQLLAB_REQUIRE_DATASET_MATCH", None) + try: + assert requires_dataset_match() is True + finally: + if original is not None: + config["SQLLAB_REQUIRE_DATASET_MATCH"] = original + + +def test_requires_dataset_match_reads_config() -> None: + with patch.dict(current_app.config, {"SQLLAB_REQUIRE_DATASET_MATCH": False}): + assert requires_dataset_match() is False + with patch.dict(current_app.config, {"SQLLAB_REQUIRE_DATASET_MATCH": True}): + assert requires_dataset_match() is True + + +def test_execute_validator_follows_config(mocker: MockerFixture) -> None: + """SQL Lab execute uses the same flag as result fetch and export.""" + raise_for_access = mocker.patch( + "superset.sqllab.validators.security_manager.raise_for_access" Review Comment: Fixed. `raise_for_access` in both tests and the `query` mock are annotated as `MagicMock`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
