codeant-ai-for-open-source[bot] commented on code in PR #44997:
URL: https://github.com/apache/superset/pull/44997#discussion_r4199506543
##########
superset/semantic_layers/models.py:
##########
@@ -679,7 +691,7 @@ def data(self) -> ExplorableData:
# sql-specific
"schema": None,
"catalog": None,
- "main_dttm_col": None,
+ "main_dttm_col": main_dttm_col,
Review Comment:
**Suggestion:** `main_dttm_col` becomes Explore’s granularity default, but
semantic views provide no granularity choices, so Explore clears the unmatched
value and new charts lose the preferred time dimension.
**Assessment:** 🟠 `Major` · 🔁 `Occurrence: Sometimes` · 🏷️ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=061e6b377006415592e6a7784e57a4e8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=061e6b377006415592e6a7784e57a4e8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/semantic_layers/models.py
**Line:** 694:694
**Comment:**
*Api Mismatch: `main_dttm_col` becomes Explore’s granularity default,
but semantic views provide no granularity choices, so Explore clears the
unmatched value and new charts lose the preferred time dimension.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44997&comment_hash=1345380669977dc725e40527871a7911567d55a1cc724c586080053dbfceb8fd&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44997&comment_hash=1345380669977dc725e40527871a7911567d55a1cc724c586080053dbfceb8fd&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
