mikebridge commented on code in PR #44997: URL: https://github.com/apache/superset/pull/44997#discussion_r4226930235
########## docs/developer_docs/extensions/contribution-types.md: ########## @@ -337,3 +337,19 @@ column picker: its dimensions are listed as Saved options and the Simple and Custom SQL modes are visible but disabled, so users cannot build an expression the backend would reject. Unknown feature strings and payloads with no `semantic_view_features` field are ignored, preserving existing behavior. + +#### Choosing a default time dimension + +A semantic view may set `preferred_time_dimension` to the name of a temporal +dimension it exposes. Superset publishes that name as `main_dttm_col`, which +Explore uses for the default time filter on new charts. The declaration is +ignored if the name is absent or does not identify a temporal dimension. + +```python +class MySemanticView(SemanticView): + preferred_time_dimension = "metric_time" Review Comment: Good call, renamed to `preferred_temporal_dimension` in f443f6090b: the core `SemanticView` declaration, host code, tests and the extension docs, plus a short UPDATING note. It's a plain rename with no compatibility alias, since nothing outside this PR uses the field yet. The declaration stays optional, and the temporal-column fallback and saved-chart behavior are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
