codeant-ai-for-open-source[bot] commented on code in PR #44909:
URL: https://github.com/apache/superset/pull/44909#discussion_r4199501435
##########
superset-frontend/packages/superset-ui-core/src/query/buildQueryContext.ts:
##########
@@ -59,9 +60,17 @@ export default function buildQueryContext(
if (isXAxisSet(formData)) {
queries = queries.map(query => normalizeTimeColumn(formData, query));
}
+ const datasource = new DatasourceKey(formData.datasource).toObject();
+ if (datasource.type === DatasourceType.SemanticView) {
+ queries = queries.map(query =>
+ (query.series_limit ?? 0) > 0 && !query.series_columns?.length
+ ? { ...query, series_limit: 0 }
+ : query,
+ );
Review Comment:
**Suggestion:** For semantic timeseries queries, this clears valid limits
when `series_columns` is omitted; the backend infers those columns from
`columns` when metrics are present.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incorrect
condition logic`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=40deec6dde3544d88d7ce2728294ee57&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=40deec6dde3544d88d7ce2728294ee57&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/query/buildQueryContext.ts
**Line:** 65:69
**Comment:**
*Incorrect Condition Logic: For semantic timeseries queries, this
clears valid limits when `series_columns` is omitted; the backend infers those
columns from `columns` when metrics are present.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44909&comment_hash=5eb8820464560b4978e95fe402d863a00bf33fb8c0c2b0a50d42b05ff4b88b71&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44909&comment_hash=5eb8820464560b4978e95fe402d863a00bf33fb8c0c2b0a50d42b05ff4b88b71&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
