aminghadersohi commented on code in PR #44909: URL: https://github.com/apache/superset/pull/44909#discussion_r4211633896
########## docs/docs/using-superset/exploring-data.mdx: ########## @@ -113,6 +113,11 @@ chart requires access to its datasource; overwriting an existing chart also requires chart edit permission. SQL Lab queries must first be saved as datasets before they can be used as persistent chart datasources. +For a semantic view, Pivot Table hides **Series limit** because it has no series +columns to limit. Existing Pivot Table charts with a saved Series limit still +run without applying that limit. Programmatic semantic-view queries with a +positive `series_limit` and no `series_columns` run without a series limit. Review Comment: NIT: timeseries queries with metrics infer `series_columns` from `columns` and keep the limit. ```suggestion positive `series_limit` and no `series_columns` run without a series limit, except timeseries queries with metrics, whose `columns` act as series columns. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
