aminghadersohi commented on code in PR #44832:
URL: https://github.com/apache/superset/pull/44832#discussion_r4211806697
##########
superset/semantic_layers/models.py:
##########
@@ -468,9 +473,11 @@ def values_for_column(
dimension.name,
exc_info=True,
)
- result = self.implementation.get_values(dimension, None)
+ with provider_completeness():
Review Comment:
Nit: no test covers this fallback. Removing this `provider_completeness()`
keeps all 742 semantic_layers tests green, though the error would escape as a
500. A case where narrowing raises a generic error and this call raises the
core error would pin it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
