mikebridge commented on code in PR #44832:
URL: https://github.com/apache/superset/pull/44832#discussion_r4213042064
##########
superset/semantic_layers/models.py:
##########
@@ -468,9 +473,11 @@ def values_for_column(
dimension.name,
exc_info=True,
)
- result = self.implementation.get_values(dimension, None)
+ with provider_completeness():
Review Comment:
Good catch — the fallback is live. I added a test for a rejected narrowing
filter followed by an incomplete or unverified core error on the unfiltered
retry. Removing the fallback translator makes both cases fail with the raw core
exception; with it present, they raise the host completeness error and preserve
the cause. The regression test is in
[6f5e01ca0d](https://github.com/apache/superset/commit/6f5e01ca0d6aa65d642817a9778cbfb68d1029da).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
