rabumaabraham opened a new pull request, #45145: URL: https://github.com/apache/superset/pull/45145
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly fix(column-config): allow commas in D3 number formats --> ### SUMMARY Add the ,.0f preset to the D3 number format options for column customization, displaying numbers with thousands separators and no decimal places (for example, 12,345). Explicitly configure token separators to use newlines, tabs, and semicolons instead of treating commas as separators. This allows users to enter comma-formatted D3 number formats without the input splitting the value. The preset is available in both D3 format and Small number format. Fixes #45136 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before <img width="1917" height="1020" alt="before superset" src="https://github.com/user-attachments/assets/5f6d89b3-1c50-459d-8193-781308e295b1"; /> #### After <img width="1917" height="1027" alt="after superset" src="https://github.com/user-attachments/assets/3c88421c-c172-49e5-bc84-247871ac1f71"; /> ### TESTING INSTRUCTIONS 1. Open a dashboard or chart in Explore. 2. Navigate to Customize → Customize columns. 3. Open the D3 format dropdown and verify that ,.0f (12,345) is available. 4. Repeat for Small number format. 5. Enter ,.0f manually in either field and verify that the comma remains part of the format. 6. Apply the configuration and verify that the displayed numbers use thousands separators and no decimal places. #### Automated checks: - npm --prefix superset-frontend test -- --watch=false ColumnConfigConstants.test.tsx - Oxlint on both changed files: 0 errors. - git diff --check: passed. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
