SBIN2010 commented on code in PR #45145:
URL: https://github.com/apache/superset/pull/45145#discussion_r4233163471
##########
superset-frontend/src/explore/components/controls/ColumnConfigControl/constants.tsx:
##########
@@ -46,17 +46,23 @@ export type SharedColumnConfigProp =
| 'displayTypeIcon'
| 'currencyFormat';
+const d3NumberFormatOptions: [string, string][] = [
+ ...D3_FORMAT_OPTIONS,
+ [',.0f', ',.0f (12,345)'],
+];
+
const d3NumberFormat: ControlFormItemSpec<'Select'> = {
allowNewOptions: true,
controlType: 'Select',
label: t('D3 format'),
description: D3_FORMAT_DOCS,
- options: D3_FORMAT_OPTIONS.map(option => ({
+ options: d3NumberFormatOptions.map(option => ({
value: option[0],
label: option[1],
})),
defaultValue: D3_FORMAT_OPTIONS[0][0],
creatable: true,
+ tokenSeparators: ['\n', '\t', ';'],
Review Comment:
In https://github.com/apache/superset/pull/37454, `tokenSeparators` was
added, excluding only the comma; a comment indicating the location of the
original constant was also added.
`// default value tokenSeparators in
superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts
tokenSeparators: ['\r\n', '\n', '\t', ';'],`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
