codeant-ai-for-open-source[bot] commented on code in PR #45133:
URL: https://github.com/apache/superset/pull/45133#discussion_r4235503051
##########
superset/semantic_layers/models.py:
##########
@@ -786,9 +786,11 @@ def result_cache_discriminator(self) -> tuple[str, str] |
None:
def get_extra_cache_keys(self, query_obj: QueryObjectDict) ->
list[Hashable]:
discriminator: tuple[str, str] | None = self.result_cache_discriminator
- if discriminator is None:
- return []
- return [("semantic-result-version", *discriminator)]
+ # Separate cached pre-normalization results during rolling deployments.
+ keys: list[Hashable] = ["semantic-null-filters-v1"]
+ if discriminator is not None:
+ keys.append(("semantic-result-version", *discriminator))
+ return keys
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag omission of the provider's metadata_cache_token from
get_extra_cache_keys; metadata invalidation is handled by the host
metadata_generation key.
**Applied to:**
- `superset/semantic_layers/models.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
