sadpandajoe commented on code in PR #45133:
URL: https://github.com/apache/superset/pull/45133#discussion_r4235621187
##########
superset/semantic_layers/models.py:
##########
@@ -786,9 +786,11 @@ def result_cache_discriminator(self) -> tuple[str, str] |
None:
def get_extra_cache_keys(self, query_obj: QueryObjectDict) ->
list[Hashable]:
discriminator: tuple[str, str] | None = self.result_cache_discriminator
- if discriminator is None:
- return []
- return [("semantic-result-version", *discriminator)]
+ # Separate cached pre-normalization results during rolling deployments.
+ keys: list[Hashable] = ["semantic-null-filters-v1"]
Review Comment:
Understood that this stays open for the coordinated fix. Until the
annotation context picks up the version marker (or the source resolution from
#45100 lands), a native chart with a chart-backed annotation layer on a
semantic chart filtered on NULL keeps serving the pre-fix cached rows after
upgrade. Should this PR wait for that change, or should UPDATING.md call out
the stale-annotation window until it ships?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
