rusackas commented on PR #35662: URL: https://github.com/apache/superset/pull/35662#issuecomment-6114103899
Thanks @nicob3y, this is shaping up nicely and the access-filter test is a good addition. The DAO method's positional arg order changed, so could you double check there are no other callers (including in tests or extensions) still passing `database_id` first? Otherwise this looks about ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
