rusackas commented on PR #35662: URL: https://github.com/apache/superset/pull/35662#issuecomment-6120842252
Thanks for sticking with this, nice feature and the docs/tests are appreciated. One thing I'd tweak: the DAO now imports `_UNSET`/`_Unset` from `jinja_context`, which feels backwards (data layer depending on the templating layer, and an import cycle waiting to happen). Could the sentinel live somewhere neutral like `superset/utils`? Also worth a quick grep to make sure nothing else calls `get_table_by_catalog_schema_and_name` with the old positional order. Otherwise this looks pretty close to me. @sadpandajoe mind giving it another look since the last round of changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
