FrancescoCastaldi commented on PR #45038:
URL: https://github.com/apache/superset/pull/45038#issuecomment-6114720813
Hi @sadpandajoe @rusackas,
Pushed commit `0786da887f` adding
`test_set_dash_metadata_does_not_double_remap_overlapping_ids` in
`tests/unit_tests/dao/dashboard_test.py`.
The test feeds overlapping mapping `{1: 2, 2: 3}` through
`DashboardDAO.set_dash_metadata` with `chartsInScope=[1, 2]`, `excluded=[1]`,
and `selectedLayers=["chart-1-layer-0"]`. It asserts `[2, 3]`, `[2]`, and
`["chart-2-layer-0"]`, verifying that single-pass remapping holds and
preventing chained remapping (1 -> 2 -> 3).
All 20 unit tests in `tests/unit_tests/dao/dashboard_test.py` pass cleanly.
Ready for final review and merge.
@coderabbitai review
@bito-code-review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
