FrancescoCastaldi commented on PR #45038: URL: https://github.com/apache/superset/pull/45038#issuecomment-6132994098
Thanks for the follow-up review @sadpandajoe! I have pushed commit `d07e3bbbed` addressing both comments: 1. **Legacy `chart_customization_config` top-level `chartId` remapping**: `DashboardDAO._remap_filter_scope` now remaps top-level `chartId` entries (guarded with `not isinstance(..., bool)`) alongside `scope` and `chartsInScope`, and unit tests now cover legacy `chart_customization_config` entries in both `copy_dashboard` and `set_dash_metadata`. 2. **Pre-commit / Ruff formatting**: Restored the two-blank-line separation before `test_set_dash_metadata_does_not_double_remap_overlapping_ids`, normalized the trailing newline, and verified `ruff check` and `ruff format` pass cleanly on both touched files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
