aminghadersohi commented on PR #44454: URL: https://github.com/apache/superset/pull/44454#issuecomment-6133714845
@mikebridge I re-reviewed the post-approval delta at 2ca9916215d87ea7154162b0ee58428e5bc7efc6 and it looks correct: whole-Dimension identity checks, the FILTER/TIME_BOUND map consolidation (same resolution either way), and the values endpoint 400 (now covered by master's `QueryObjectValidationError` handler). The branch now conflicts with master (UPDATING.md, creating-your-first-dashboard.mdx, superset/semantic_layers/mapper.py, after https://github.com/apache/superset/pull/45105). Could you merge master? I'll merge once it's green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
