sadpandajoe commented on code in PR #44945:
URL: https://github.com/apache/superset/pull/44945#discussion_r4253082293
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx:
##########
@@ -95,7 +95,6 @@ export default function RadioButtonControl({
}`}
onClick={e => {
e.currentTarget?.focus();
Review Comment:
With the `onChange` removed from this click handler, clicking the option
that is already shown as selected no longer reports anything. In the Table
column-config form, `horizontalAlign` falls back to `defaultValue: 'right'` for
numeric columns with nothing saved, but with time comparison enabled
`TableChart` renders an unsaved alignment as `left` (`TableChart.tsx`
`getSharedStyle`). A user who sees "right" highlighted and clicks it to get
right alignment now gets no change, and the value is never persisted unless
they click another option first. Is that no-op intended for controls whose
displayed default differs from what is stored, or should those still be able to
commit the default on click?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
