FrancescoCastaldi commented on code in PR #44945:
URL: https://github.com/apache/superset/pull/44945#discussion_r4257053681
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx:
##########
@@ -95,7 +95,6 @@ export default function RadioButtonControl({
}`}
onClick={e => {
e.currentTarget?.focus();
Review Comment:
Addressed in commit 9f71370. Updated ControlFormItem to forward initialValue
unmasked to dynamic controls, and extended RadioButtonControlProps with an
explicit initialValue prop. When initialValue is unpersisted (such as when
ControlFormItem seeds value with defaultValue), clicking the displayed default
triggers onChange to persist the setting into the column configuration, while
already-persisted values remain a no-op. Added unit test coverage for both
unpersisted and persisted initialValue scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
