mikebridge commented on PR #45147: URL: https://github.com/apache/superset/pull/45147#issuecomment-6134567938
Codex follow-up to the picker point in [Amin’s review](https://github.com/apache/superset/pull/45147#pullrequestreview-5496935781): this is now fixed rather than left as a frontend follow-up. Semantic-view 400s show the backend’s sanitized guidance through `getClientErrorObject`, with a generic suggestions note if guidance is empty. Manual values remain available. SQL-dataset 400 behavior is unchanged. The request guard runs after the asynchronous body parse, so a delayed old rejection cannot replace a newer successful search. New Jest cases cover guidance/manual entry, the bounded-page hint, and that delayed-body race; all 53 component cases pass. The semantic truncation hint no longer promises whole-column search, and the API q description distinguishes text search from bounded non-text semantic suggestions. String-view and dictionary text narrowing is fixed too. Backend/core/async checks pass all 983 cases; branch-wide hooks and independent Claude review pass. #45110 is unchanged; no restack was needed. Pushed in `1347e8348d`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
