mikebridge commented on PR #45147: URL: https://github.com/apache/superset/pull/45147#issuecomment-6129198185
Codex validation of CodeAnt’s completeness concern at `04b2ab7cc9eb`: this is already handled, so no code change is needed. `provider_completeness()` translates the SDK completeness signal into the host `SemanticResultCompletenessError`, which subclasses `QueryObjectValidationError`. The execution wrapper explicitly re-raises that class before its generic-fault handler, preserving completeness classification rather than converting it to a 500. Host completeness errors raised directly follow the same path. I reran 17 existing regression cases covering core/host incomplete and unverified errors, HTTP 400 and guest sanitization, async failure reasons without success publication, and value-search/endpoint failures without retry or cache writes. All passed on the assessed head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
