aminghadersohi commented on code in PR #45103:
URL: https://github.com/apache/superset/pull/45103#discussion_r4254497951
##########
.github/workflows/bashlib.sh:
##########
@@ -295,6 +295,30 @@ playwright-run() {
return $status
}
+playwright-run-semantic() {
+ # The semantic-layer REST APIs only register when SEMANTIC_LAYERS is on, and
+ # Superset builds AppBuilder with update_perms=False, so their permissions
+ # exist only after a `superset init` that sees the flag. playwright_testdata
+ # ran init under the base test config, so sync roles again under this step's
+ # config before `playwright-run` boots gunicorn with it -- the same thing a
+ # deployment does after turning the flag on. Without it Admin gets 403 on
+ # POST /api/v1/semantic_layer/.
Review Comment:
https://github.com/apache/superset/pull/45061, already on master, registers
the semantic APIs regardless of `SEMANTIC_LAYERS`, so the base `superset init`
creates these perms and this rationale (and the yml comment) is false after
merge. No suggestion: the re-init is needed until you rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
