mikebridge commented on code in PR #45103:
URL: https://github.com/apache/superset/pull/45103#discussion_r4254781485
##########
.github/workflows/bashlib.sh:
##########
@@ -295,6 +295,30 @@ playwright-run() {
return $status
}
+playwright-run-semantic() {
+ # The semantic-layer REST APIs only register when SEMANTIC_LAYERS is on, and
+ # Superset builds AppBuilder with update_perms=False, so their permissions
+ # exist only after a `superset init` that sees the flag. playwright_testdata
+ # ran init under the base test config, so sync roles again under this step's
+ # config before `playwright-run` boots gunicorn with it -- the same thing a
+ # deployment does after turning the flag on. Without it Admin gets 403 on
+ # POST /api/v1/semantic_layer/.
Review Comment:
Thanks @aminghadersohi — agreed. Merged master in cd34a88a55 and removed the
redundant `superset init` plus the stale bashlib/workflow comments in
d7b612d238.
Both semantic REST APIs are registered unconditionally on the merged tree.
The base init calls `appbuilder.add_permissions(update_perms=True)` before
syncing roles, so it already creates their permissions. The semantic stub
config guard, step-scoped environment and required-stub check remain intact.
The shell regression check and 24 focused stub tests pass, along with all
branch-file hooks. [E2E run
38345256942](https://github.com/apache/superset/actions/runs/38345256942)
passed on this exact head, including the Semantic View Tests at both `/` and
`/app/prefix`, and both async jobs.
_Checked and updated by Codex on Mike’s behalf._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
