rusackas opened a new pull request, #45244: URL: https://github.com/apache/superset/pull/45244
### SUMMARY Found while building [preset-io/superset-extension-notifications](https://github.com/preset-io/superset-extension-notifications) (the SIP-96 extension POC, see apache/superset#44101): `superset-extensions-cli init`'s scaffolded `frontend/package.json` is out of sync with the host it's meant to target. - `react`/`react-dom` peerDependencies were pinned to `^17.0.2`; the host (`superset-frontend/package.json`) is on `^18.3.0`. Every freshly scaffolded extension starts with a peer-dependency mismatch against its own host. - `@types/react` devDependency was `^19.0.10`, which doesn't even bracket the host's actual `^18.3.0`. - `@apache-superset/core` was only listed in `peerDependencies`, not `devDependencies`. The [quick-start docs](https://github.com/apache/superset/blob/master/docs/developer_docs/extensions/quick-start.md) say explicitly it needs to be in both ("to provide TypeScript types during build") — without the dev dependency, a fresh scaffold fails `tsc` with `TS2307: Cannot find module '@apache-superset/core'`. This PR fixes all three in the template. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — template-only change, no UI. ### TESTING INSTRUCTIONS ```bash pytest superset-extensions-cli/tests/ ``` 275 passed. Also manually confirmed `superset-extensions init --frontend` with the fixed template produces a `package.json` whose declared deps match the host and whose `tsc` run resolves `@apache-superset/core` types without `--legacy-peer-deps` gymnastics. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
