rusackas commented on code in PR #45244:
URL: https://github.com/apache/superset/pull/45244#discussion_r4283543180
##########
superset-extensions-cli/src/superset_extensions_cli/templates/frontend/package.json.j2:
##########
@@ -15,13 +15,14 @@
"description": "",
"peerDependencies": {
"@apache-superset/core": "*",
- "react": "^17.0.2",
- "react-dom": "^17.0.2"
+ "react": "^18.3.0",
+ "react-dom": "^18.3.0"
},
"devDependencies": {
+ "@apache-superset/core": "^0.1.0",
Review Comment:
Good catch, confirmed it with a fresh `init --frontend` + `npm i`, it's a
real ERESOLVE. My manual test earlier didn't hit this (already had node_modules
around). Pushed `--legacy-peer-deps` onto the scaffold's install step in
7a97ea8033 rather than waiting on a core republish to widen the peer range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
