FrancescoCastaldi commented on PR #43695: URL: https://github.com/apache/superset/pull/43695#issuecomment-6180706431
@sadpandajoe thanks for the review, all three points are addressed in 58d7510. **Databricks catalog/schema resolution** - `adjust_engine_params` now resets the schema to `"default"` only when the caller switches away from a catalog explicitly configured on the connection (connect_args or `?catalog=`). - On a connection with no configured catalog, the catalog resolved by `get_default_catalog()` is treated as the server default, so the URI schema is kept (`main.finance.orders`, not `main.default.orders`). - Tests cover the two paths you suggested (`/finance` with no catalog and `/finance?catalog=main`, both called with `catalog="main"`, now resolving `finance`) plus an actual switch from `main` to `other`, which still resolves `"default"`. **Lint and formatting** - `ruff format` (0.9.7, as pinned in requirements/development.txt) applied to `databricks.py` and `test_databricks.py`. - `import io` moved into the stdlib group in `test_lint_metadata.py` (I001). **Verification** - `ruff check` and `ruff format --check` clean on `superset/db_engine_specs` and `tests/unit_tests/db_engine_specs`. - `pytest tests/unit_tests/db_engine_specs/`: 2170 passed locally. The only failures are driver/environment specific on my Windows box (pyhive, cockroach dialect, local databricks-sqlalchemy version) and reproduce on the previous commit too, so they are unrelated to this change. Ready for another look when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
