sadpandajoe commented on code in PR #43695:
URL: https://github.com/apache/superset/pull/43695#discussion_r4281055978
##########
superset/db_engine_specs/databricks.py:
##########
@@ -1011,6 +1019,68 @@ def build_sqlalchemy_uri( # type: ignore
query=query,
).render_as_string(hide_password=False)
+ @classmethod
+ def adjust_engine_params(
+ cls,
+ uri: URL,
+ connect_args: dict[str, Any],
+ catalog: str | None = None,
+ schema: str | None = None,
+ ) -> tuple[URL, dict[str, Any]]:
+ adjusted_connect_args = connect_args.copy()
+
+ original_catalog = (
Review Comment:
The pre-commit check on this head still modifies `databricks.py`, so it
fails until the hook output is committed: `auto-walrus` folds
`effective_catalog = catalog or original_catalog` into the later `if
effective_catalog:`, and `ruff-format` then rewrites the resulting `if
(effective_catalog := ...)` to drop the parentheses. Running `ruff format`
alone doesn't reproduce it. Could you run the full pre-commit hooks on
`databricks.py` and push the result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
