[GitHub] [incubator-superset] suddjian opened a new pull request #9337: Filter owners select by text input

[GitBox]

suddjian opened a new pull request #9337: Filter owners select by text input
URL: https://github.com/apache/incubator-superset/pull/9337
 
 
   ### CATEGORY
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   The owners input on the Properties modals for charts+dashboards currently 
makes one request for all the users at mount. This doesn't work on 
installations with hundreds of users, due to API response limits. This PR loads 
owner options on each keystroke so you can search for users.
   
   I used `react-select`'s async functionality, which also caches results to 
reduce api calls.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Haven't typed anything yet
   <img width="429" alt="Screen Shot 2020-03-20 at 1 12 13 PM" 
src="https://user-images.githubusercontent.com/1858430/77202943-89615d00-6aac-11ea-9eba-e138961fa8b8.png";>
   After typing, results are filtered
   <img width="438" alt="Screen Shot 2020-03-20 at 1 12 23 PM" 
src="https://user-images.githubusercontent.com/1858430/77202964-92eac500-6aac-11ea-95e4-3d99023ee51f.png";>
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat @nytai 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org