dpgaspar commented on a change in pull request #9337: Filter owners select by
text input
URL:
https://github.com/apache/incubator-superset/pull/9337#discussion_r395924980
##########
File path: superset-frontend/src/explore/components/PropertiesModal.tsx
##########
@@ -110,34 +109,39 @@ function PropertiesModal({ slice, onHide, onSave }:
InternalProps) {
// get the owners of this slice
useEffect(() => {
- fetchOwners();
+ fetchChartData();
}, []);
- // get the list of users who can own a chart
- useEffect(() => {
+ const loadOptions = (input = '') =>
SupersetClient.get({
- endpoint: `/api/v1/chart/related/owners`,
- }).then(res => {
- const { result } = res.json as Json;
- setOwnerOptions(
- result.map((item: any) => ({
+ endpoint: `/api/v1/chart/related/owners?filter=${input}`,
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
