[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #9350: [dashboard] handle markdown error

[GitBox]

graceguo-supercat opened a new pull request #9350: [dashboard] handle markdown 
error
URL: https://github.com/apache/incubator-superset/pull/9350
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [x] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Superset Dashboard allow user to add markdown component with Markdown 
syntax. But user that not familiar with html may type invalid html tags that 
cause react throws exception and break whole page. 
   
   ### BEFORE
   when user open a dashboard with bad markdown component, or adding a bad 
markdown into dashboard in edit mode:
   <img width="1304" alt="Screen Shot 2020-03-11 at 10 48 12 AM" 
src="https://user-images.githubusercontent.com/27990562/77349737-b30ec400-6cf8-11ea-82fb-04f09a9b4e72.png";>
   
   ### AFTER
   
   - if user opens a dashboard with bad markdown component:
   <img width="1060" alt="Screen Shot 2020-03-11 at 8 13 19 PM" 
src="https://user-images.githubusercontent.com/27990562/77349903-f6693280-6cf8-11ea-9e2e-ac846c860e46.png";>
   
   - if user adds a bad component in edit mode:
   <img width="1056" alt="Screen Shot 2020-03-11 at 8 16 03 PM" 
src="https://user-images.githubusercontent.com/27990562/77350123-4811bd00-6cf9-11ea-9886-d3f5981115f8.png";>
   
   ### TEST PLAN
   Manual test
   
   
   ### REVIEWERS
   @etr2460 @williaster 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org