graceguo-supercat commented on a change in pull request #9350: [dashboard]
handle markdown error
URL:
https://github.com/apache/incubator-superset/pull/9350#discussion_r398162832
##########
File path:
superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx
##########
@@ -65,14 +69,16 @@ const propTypes = {
const defaultProps = {};
-const markdownPlaceHolder = `# ✨Markdown
+const MARKDOWN_PLACE_HOLDER = `# ✨Markdown
## ✨Markdown
### ✨Markdown
<br />
Click here to edit [markdown](https://bit.ly/1dQOfRK)`;
+const MARKDOWN_ERROR_MESSAGE = t('This markdown component has an error.');
Review comment:
I rename 2 pre-defined markdown constant as `MARKDOWN_ERROR_MESSAGE` and
`MARKDOWN_PLACE_HOLDER `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
