rusackas commented on a change in pull request #9372: upgrade to
react-bootstrap v0.33.1
URL:
https://github.com/apache/incubator-superset/pull/9372#discussion_r398161071
##########
File path:
superset-frontend/src/dashboard/components/filterscope/FilterFieldTree.jsx
##########
@@ -25,7 +25,7 @@ import renderFilterFieldTreeNodes from
'./renderFilterFieldTreeNodes';
import { filterScopeSelectorTreeNodePropShape } from '../../util/propShapes';
const propTypes = {
- activeKey: PropTypes.oneOfType([null, PropTypes.string]),
+ activeKey: PropTypes.oneOfType([PropTypes.string]),
Review comment:
Maybe there's a good reason not to simplify this, but it caught my eye :)
```suggestion
activeKey: PropTypes.string,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
