rusackas commented on a change in pull request #9372: upgrade to react-bootstrap v0.33.1 URL: https://github.com/apache/incubator-superset/pull/9372#discussion_r398162569
########## File path: superset-frontend/src/dashboard/components/filterscope/FilterScopeTree.jsx ########## @@ -34,7 +34,7 @@ const propTypes = { ).isRequired, onCheck: PropTypes.func.isRequired, onExpand: PropTypes.func.isRequired, - selectedChartId: PropTypes.oneOfType([null, PropTypes.number]), + selectedChartId: PropTypes.oneOfType([PropTypes.number]), Review comment: Same here, if warranted ¯\\\_(ツ)\_/¯ ```suggestion selectedChartId: PropTypes.number, ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org