ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL:
https://github.com/apache/incubator-superset/pull/9490#discussion_r406063085
##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/load.js
##########
@@ -49,12 +49,15 @@ export default () =>
it('should load dashboard', () => {
// wait and verify one-by-one
cy.wait(aliases).then(requests => {
- requests.forEach(async xhr => {
- expect(xhr.status).to.eq(200);
- const responseBody = await readResponseBlob(xhr.response.body);
- expect(responseBody).to.have.property('error', null);
- cy.get(`#slice-container-${xhr.response.body.form_data.slice_id}`);
- });
+ return Promise.all(
+ requests.map(async xhr => {
+ expect(xhr.status).to.eq(200);
+ const responseBody = await readResponseBlob(xhr.response.body);
+ expect(responseBody).to.have.property('error', null);
+ const sliceId = responseBody.form_data.slice_id;
+ cy.get(`#chart-id-${sliceId}`).should('be.visible');
Review comment:
Has to return a `Promise` for the test cases to be captured.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
