ktmud commented on a change in pull request #9490: [Build] Add Github workflows
URL:
https://github.com/apache/incubator-superset/pull/9490#discussion_r406502040
##########
File path:
superset-frontend/cypress-base/cypress/integration/explore/visualizations/big_number.js
##########
@@ -56,8 +56,8 @@ export default () =>
it('should work', () => {
verify(BIG_NUMBER_FORM_DATA);
- cy.get('.chart-container .header_line');
- cy.get('.chart-container .subheader_line');
+ cy.get('.chart-container .header-line');
+ cy.get('.chart-container .subheader-line');
Review comment:
`explore/visualizations/index.test.js` was probably unintentioally disabled
by https://github.com/apache/incubator-superset/pull/6241 .
It has since stopped running for over a year now. A lot of these tests are
now broken. It's easy to add them back, but we may want to do the fix in
another PR. Keep the changes for BigNumber here just for reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
