ktmud commented on a change in pull request #9500: control to turn off table
bar-chart backgrounds
URL:
https://github.com/apache/incubator-superset/pull/9500#discussion_r406985276
##########
File path: superset-frontend/src/explore/controlPanels/Table.js
##########
@@ -183,6 +183,21 @@ export default {
},
},
],
+ [
+ {
+ name: 'hide_cell_bars',
Review comment:
I'd say make this a default "on" control called "Display metrics with bars"
to [avoid a double
negative.](https://learningenglish.voanews.com/a/everyday-grammar-double-negatives/2743416.html).
1. It's more intuitive to make all visibility control about show something
optional.
2. We should probably disable this bar chart by default anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
