rusackas commented on a change in pull request #9500: control to turn off table
bar-chart backgrounds
URL:
https://github.com/apache/incubator-superset/pull/9500#discussion_r406988026
##########
File path: superset-frontend/src/explore/controlPanels/Table.js
##########
@@ -183,6 +183,21 @@ export default {
},
},
],
+ [
+ {
+ name: 'hide_cell_bars',
Review comment:
I wrestled with the same thought, and built it that way initially. I
inverted it, thinking that we'd have to do a migration for existing charts so
people don't have to go toggle it "on" for every existing chart... but... I
wound up setting a default for that prop anyway, so uh... I'll switch it back.
Thanks for taking a critical look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
