etr2460 opened a new pull request #9684: URL: https://github.com/apache/incubator-superset/pull/9684
### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY At Airbnb, we see a decent number of errors like `No grain spec for day for database presto`. It appears that this is because we never merged a migration to move slices from the old type to the new one (see https://github.com/apache/incubator-superset/pull/4755#issuecomment-401981272). I've replicated/updated @jeffreythewang's work (thanks Jeffrey!) from https://github.com/apache/incubator-superset/pull/5485 in this PR to migrate slices to the proper time grain format ### TEST PLAN set `time_grain_sqla` for a chart to "day", run the migration and see it converted to "P1D" ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [x] Requires DB Migration. - [x] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @john-bodley @villebro @mistercrunch @jeffreythewang ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
