blcksrx commented on pull request #9825:
URL: 
https://github.com/apache/incubator-superset/pull/9825#issuecomment-664961215


   > Hi @blcksrx and @villebro thanks for bringing this feature to Superset! 
Today when I first tried this feature it gave me this error: "AttributeError: 
'SupersetSecurityManager' object has no attribute 'database_access'", but when 
I changed ` security_manager.database_access(database)` to 
`security_manager.can_access_database(database)` it worked. I don't quite 
understand why the change works, so could you guys help me with this? Cheers!
   > ![Screen Shot 2020-07-21 at 10 25 52 
am](https://user-images.githubusercontent.com/49756587/87999093-315f6380-cb3d-11ea-95c8-3be5eacb00f1.png)
   > <img alt="Screen Shot 2020-07-21 at 10 25 09 am" width="656" 
src="https://user-images.githubusercontent.com/49756587/87999099-358b8100-cb3d-11ea-907a-9367a2753d18.png";>
   
   Hi. it seems, there are some other commits that above my commit that changes 
the `database_access` to the `can_access_database` and the commiters forgot to 
change this on my commit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to