bkyryliuk commented on a change in pull request #10436:
URL:
https://github.com/apache/incubator-superset/pull/10436#discussion_r461183127
##########
File path: tests/database_api_tests.py
##########
@@ -252,6 +252,24 @@ def test_schemas(self):
response = json.loads(rv.data.decode("utf-8"))
self.assertEqual(0, len(response["result"]))
+ def test_database_schemas(self):
Review comment:
suggestion: there are some complexity due to the api pagination, it may
be useful to test it as well
e.g. @nytai helped me to figure out that
https://github.com/dropbox/incubator-superset-internal/commit/a7aec30301a363df96f9d723ba9a36d7894f5012
setting max_page_size = -1 and page_size = -1 breaks some assumptions about
pagination apis & it's not covered by unit test.
##########
File path: tests/database_api_tests.py
##########
@@ -252,6 +252,24 @@ def test_schemas(self):
response = json.loads(rv.data.decode("utf-8"))
self.assertEqual(0, len(response["result"]))
+ def test_database_schemas(self):
Review comment:
suggestion: there are some complexity due to the api pagination, it may
be useful to test it as well
e.g. @nytai helped me to figure out that
https://github.com/dropbox/incubator-superset-internal/commit/a7aec30301a363df96f9d723ba9a36d7894f5012
setting max_page_size = -1 and page_size = -1 breaks some assumptions about
pagination apis & it's not covered by unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
