mistercrunch commented on pull request #10486:
URL:
https://github.com/apache/incubator-superset/pull/10486#issuecomment-666857463
Overall the approach of wrapping all `antd` components is going to be a fair
amount of boilerplate code, but I think it's worth it overall for the
flexibility it offers:
- reducing the props to a subset of the ones exposed by antd helps
simplifying the component interface surface, creates more visual consistency in
Superset
- allows for rewiring/styling abstraction to be all in one place
- {more! just can't think of it just now}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]