nruhe edited a comment on pull request #10486: URL: https://github.com/apache/incubator-superset/pull/10486#issuecomment-670223434
> reducing the props to a subset of the ones exposed by antd helps simplifying the component interface surface, creates more visual consistency in Superset @mistercrunch Aside from the style props, we should generally avoid limiting the properties antd exposes to us. Doing so just makes the components less flexible and will lead to bad designs in the long run. Looking at you `QueryButton, Button, BootstrapButton, SubmitButton` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
