parshimers commented on code in PR #4134: URL: https://github.com/apache/texera/pull/4134#discussion_r2684183858
########## LICENSE: ########## @@ -204,35 +204,45 @@ THIRD-PARTY DEPENDENCIES -------------------------------------------------------------------------------- -This product bundles source code from third-party projects. See licenses/ for -the full text of these licenses: +This product bundles source code and assets from third-party projects. +See licenses/ for the full text of these licenses: - licenses/LICENSE-MIT.txt - licenses/LICENSE-CC-BY-3.0.txt -MIT License ------------ +MIT License (licenses/LICENSE-MIT.txt) +-------------------------------------- This product bundles code derived from mbknor-jackson-jsonschema: - common/workflow-operator/src/main/scala/com/kjetland/jackson/jsonSchema/ Copyright (c) 2016 Kjell Tore Eliassen (mbknor) Source: https://github.com/mbknor/mbknor-jackson-jsonschema -This product bundles code derived from Angular examples: +This product bundles code derived from Google Angular formly examples: - frontend/src/app/common/formly/array.type.ts - frontend/src/app/common/formly/object.type.ts - frontend/src/app/common/formly/multischema.type.ts - frontend/src/app/common/formly/null.type.ts Copyright (c) 2018 Google Inc. All Rights Reserved. Source: https://angular.io -SVG Icons ---------- - -This product includes SVG icons from third-party sources: +This product bundles code derived from TypeFox monaco-languageclient: + - pyright-language-service/src/main.ts + - pyright-language-service/src/language-server-runner.ts + - pyright-language-service/src/server-commons.ts + Copyright (c) 2024 TypeFox and others. + Source: https://github.com/TypeFox/monaco-languageclient +This product includes an SVG icon from SVGRepo: - frontend/src/assets/svg/operator-view-result.svg - Source: SVGRepo (https://www.svgrepo.com) - License: MIT License + Source: https://www.svgrepo.com + License: MIT License + +CC BY 3.0 License (licenses/LICENSE-CC-BY-3.0.txt) +-------------------------------------------------- + +NOTE: The following files use CC BY 3.0 license which requires attribution. Review Comment: it's not that they should be removed in the release, it's that they can only be packaged with binaries and not as part of the source release. it's not exactly clear to me how this applies to a svg. it is textual but not in the way source code is usually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
