bobbai00 commented on code in PR #4134:
URL: https://github.com/apache/texera/pull/4134#discussion_r2684313858


##########
pyright-language-service/src/types/hocon-parser.d.ts:
##########
@@ -1,3 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+

Review Comment:
   I didn't find the original file from TypeFox. Should I reach out to the 
people who introduced this file to confirm?



##########
LICENSE:
##########
@@ -204,35 +204,45 @@
 THIRD-PARTY DEPENDENCIES
 
--------------------------------------------------------------------------------
 
-This product bundles source code from third-party projects. See licenses/ for
-the full text of these licenses:
+This product bundles source code and assets from third-party projects.
+See licenses/ for the full text of these licenses:
   - licenses/LICENSE-MIT.txt
   - licenses/LICENSE-CC-BY-3.0.txt
 
-MIT License
------------
+MIT License (licenses/LICENSE-MIT.txt)
+--------------------------------------
 
 This product bundles code derived from mbknor-jackson-jsonschema:
   - common/workflow-operator/src/main/scala/com/kjetland/jackson/jsonSchema/
   Copyright (c) 2016 Kjell Tore Eliassen (mbknor)
   Source: https://github.com/mbknor/mbknor-jackson-jsonschema
 
-This product bundles code derived from Angular examples:
+This product bundles code derived from Google Angular formly examples:
   - frontend/src/app/common/formly/array.type.ts
   - frontend/src/app/common/formly/object.type.ts
   - frontend/src/app/common/formly/multischema.type.ts
   - frontend/src/app/common/formly/null.type.ts
   Copyright (c) 2018 Google Inc. All Rights Reserved.
   Source: https://angular.io
 
-SVG Icons
----------
-
-This product includes SVG icons from third-party sources:
+This product bundles code derived from TypeFox monaco-languageclient:
+  - pyright-language-service/src/main.ts
+  - pyright-language-service/src/language-server-runner.ts
+  - pyright-language-service/src/server-commons.ts
+  Copyright (c) 2024 TypeFox and others.
+  Source: https://github.com/TypeFox/monaco-languageclient
 
+This product includes an SVG icon from SVGRepo:
   - frontend/src/assets/svg/operator-view-result.svg
-    Source: SVGRepo (https://www.svgrepo.com)
-    License: MIT License
+  Source: https://www.svgrepo.com
+  License: MIT License
+
+CC BY 3.0 License (licenses/LICENSE-CC-BY-3.0.txt)
+--------------------------------------------------
+
+NOTE: The following files use CC BY 3.0 license which requires attribution.

Review Comment:
   fixed. I removed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to