aicam commented on code in PR #4191:
URL: https://github.com/apache/texera/pull/4191#discussion_r2770894502
##########
access-control-service/src/main/scala/org/apache/texera/service/resource/AccessControlResource.scala:
##########
@@ -121,12 +121,20 @@ object AccessControlResource extends LazyLogging {
return Response.status(Response.Status.FORBIDDEN).build()
}
+ // Dynamic Routing Logic
+ val workflowComputingUnitPoolName =
sys.env.getOrElse("WORKFLOW_COMPUTING_UNIT_POOL_NAME",
"texera-workflow-computing-unit-pool")
Review Comment:
I had a discussion with @kunwp1 about this and this was our conclusion:
- `Config`: A property that is stored in `.conf` files and is saved in
Postgres in initialization and then `Config Service` can expose it to API, or
just use internally and can be changed
- `Kubernetes Value`: A property that stored in `values.yaml` and setup
Kubernetes and we want to be exposed in `values.yaml` to easily modify
deployments with override files
Computing unit namespaces is a Kubernetes configuration that we typically
apply using override files and are not stored in Config files, in this regard,
I prefer to keep it this way. It is also notable that we use same ad-hoc ENV
reading for `TEXERA_HOME`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
