bobbai00 commented on code in PR #4191:
URL: https://github.com/apache/texera/pull/4191#discussion_r2771443214
##########
bin/k8s/values.yaml:
##########
@@ -253,29 +236,14 @@ texeraEnvVars:
value: ""
- name: USER_SYS_DOMAIN
value: ""
-
-# Ingress dependency configs
-ingress-nginx:
- enabled: true # set to true if nginx is not installed, should be false in
production
- controller:
- replicaCount: 1
- service:
- type: NodePort
- nodePorts:
- http: 30080
- ingressClassResource:
- name: nginx
- enabled: true
- resources:
- limits:
- cpu: 100m
- memory: 128Mi
- requests:
- cpu: 100m
- memory: 128Mi
- rbac:
- create: true
-
+ - name: GUI_LOGIN_DEFAULT_LOCAL_USER_USERNAME
Review Comment:
Is this change needed?
##########
bin/k8s/values.yaml:
##########
@@ -30,7 +30,7 @@ persistence:
minioHostLocalPath: ""
postgresqlHostLocalPath: ""
-# Part 1: the configuration of Postgres, Minio and LakeFS
+# Part 1: configuration of Postgres, Minio and LakeFS
Review Comment:
revert this change
##########
bin/k8s/templates/gateway-routes.yaml:
##########
@@ -0,0 +1,142 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+apiVersion: gateway.networking.k8s.io/v1
+kind: HTTPRoute
+metadata:
+ name: {{ .Release.Name }}-static-routes
+ namespace: {{ .Release.Namespace }}
+spec:
+ parentRefs:
+ - name: {{ .Release.Name }}-gateway
+ {{- if and .Values.gatewayConfig .Values.gatewayConfig.hostname }}
+ hostnames:
+ - {{ .Values.gatewayConfig.hostname }}
+ {{- end }}
+ rules:
+ - matches:
+ - path:
+ type: PathPrefix
+ value: /api/computing-unit
+ backendRefs:
+ - name: workflow-computing-unit-manager-svc
+ port: 8888
+ - matches:
+ - path:
+ type: PathPrefix
+ value: /api/compile
+ backendRefs:
+ - name: workflow-compiling-service-svc
+ port: 9090
+ - matches:
+ - path:
+ type: PathPrefix
+ value: /api/dataset
+ - path:
+ type: PathPrefix
+ value: /api/access/dataset
+ backendRefs:
+ - name: file-service-svc
+ port: 9092
+ - matches:
+ - path:
+ type: PathPrefix
+ value: /api/access/computing-unit
+ backendRefs:
+ - name: workflow-computing-unit-manager-svc
+ port: 8888
+ - matches:
+ - path:
+ type: PathPrefix
+ value: /api/config
+ backendRefs:
+ - name: config-service-svc
+ port: 9094
+ - matches:
+ - path:
+ type: PathPrefix
+ value: /rtc
+ backendRefs:
+ - name: y-websocket-server-svc
+ port: 1234
+ - matches:
+ - path:
+ type: PathPrefix
+ value: /python-language-server
+ backendRefs:
+ - name: python-language-server-svc
+ port: 3000
+ - matches:
+ - path:
+ type: PathPrefix
+ value: /api
+ - path:
+ type: PathPrefix
+ value: /
+ backendRefs:
+ - name: webserver-svc
+ port: 8080
+---
+apiVersion: gateway.networking.k8s.io/v1
+kind: HTTPRoute
+metadata:
+ name: texera-dynamic-routes
Review Comment:
make it Release.name
##########
bin/k8s/values.yaml:
##########
@@ -106,11 +103,10 @@ lakefs:
access_key_id: texera_minio
secret_access_key: password
-# Part2: configurations of Texera-related micro services
+# Part 2: configurations of Texera-related micro services
texeraImages:
Review Comment:
ditto
##########
bin/k8s/values.yaml:
##########
@@ -308,56 +276,34 @@ metrics-server:
create: true
serviceAccount:
create: true
- priorityClassName: system-cluster-critical
-# Custom Ingress resource configs
-ingressPaths:
- enabled: true
- ingressClassName: nginx # Set to "alb" when deploying on AWS
+gatewayConfig:
Review Comment:
Write some comments about:
- what are these configurations
- if developers need to change the routing rule, which file to look at
##########
bin/k8s/values.yaml:
##########
@@ -253,29 +236,14 @@ texeraEnvVars:
value: ""
- name: USER_SYS_DOMAIN
value: ""
-
-# Ingress dependency configs
-ingress-nginx:
- enabled: true # set to true if nginx is not installed, should be false in
production
- controller:
- replicaCount: 1
- service:
- type: NodePort
- nodePorts:
- http: 30080
- ingressClassResource:
- name: nginx
- enabled: true
- resources:
- limits:
- cpu: 100m
- memory: 128Mi
- requests:
- cpu: 100m
- memory: 128Mi
- rbac:
- create: true
-
+ - name: GUI_LOGIN_DEFAULT_LOCAL_USER_USERNAME
Review Comment:
move it to different PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
