mengw15 commented on code in PR #4272:
URL: https://github.com/apache/texera/pull/4272#discussion_r3012564609
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/core/storage/result/iceberg/IcebergTableWriter.scala:
##########
@@ -107,10 +106,12 @@ private[storage] class IcebergTableWriter[T](
private def flushBuffer(): Unit = {
if (buffer.nonEmpty) {
// Create a unique file path using the writer's identifier and the
filename index
- val filepath =
Paths.get(table.location()).resolve(s"${writerIdentifier}_${filenameIdx}")
+ val location = table.location()
+ val basePath = if (location.endsWith("/")) location else s"$location/"
Review Comment:
also I think \ is a problem introduced by java.nio.file.Paths — Paths.get()
converts paths to OS-native format, which uses \ on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
