mengw15 commented on code in PR #4272:
URL: https://github.com/apache/texera/pull/4272#discussion_r3013021226
##########
amber/src/main/python/core/storage/iceberg/test_iceberg_document.py:
##########
@@ -37,16 +37,19 @@
# Hardcoded storage config only for test purposes.
StorageConfig.initialize(
+ catalog_type="postgres",
postgres_uri_without_scheme="localhost:5432/texera_iceberg_catalog",
postgres_username="texera",
postgres_password="password",
+ rest_catalog_uri="http://localhost:8181/catalog/";,
+ rest_catalog_warehouse_name="texera",
table_result_namespace="operator-port-result",
directory_path="../../../../../../amber/user-resources/workflow-results",
commit_batch_size=4096,
s3_endpoint="http://localhost:9000";,
- s3_region="us-east-1",
- s3_auth_username="minioadmin",
- s3_auth_password="minioadmin",
+ s3_region="us-west-2",
Review Comment:
I think the S3 credentials in test_iceberg_document.py were added by the
Large Binary PR, which used the MinIO default (minioadmin). That PR's own tests
(test_large_binary_manager.py) are mocked so the credentials don't matter. But
test_iceberg_document.py is an integration test that will connects to a real
MinIO instance, so I updated the credentials to match what's configured in
docker-compose. This way developers can run the integration tests locally
against their docker-compose MinIO without extra configuration. A follow-up PR
will also start MinIO in CI using the same credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
